Redesign storyline header with Moleskine cover + info panel#794
Merged
realproject7 merged 3 commits intomainfrom Apr 3, 2026
Merged
Redesign storyline header with Moleskine cover + info panel#794realproject7 merged 3 commits intomainfrom
realproject7 merged 3 commits intomainfrom
Conversation
Replace plain text header with Moleskine book cover (left) + structured info panel (right) layout inspired by Korean web fiction stores. - Desktop: cover left, info right with label-value rows - Mobile: cover centered on top, info below - Reuses Moleskine notebook styling from Reader tab holdings cards - Info panel: title, rating+views, writer with PFP, plots, genre - Market stats grid preserved below Fixes #785 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
requested changes
Apr 3, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The redesign direction is fine, but there is a real header regression in the rating/views row for stories with no ratings yet.
Findings
- [medium]
RatingSummaryreturnsnullwhen a storyline has zero ratings, but the separator dot is rendered unconditionally. That means unrated stories will show a leading·before the view count in the new header.- File:
src/app/story/[storylineId]/page.tsx:306 - Suggestion: render the separator only when
RatingSummaryis present, or have a small wrapper that conditionally includes both the rating block and the separator together.
- File:
Decision
Requesting changes because the redesign introduces a visible regression for unrated storylines.
Create RatingSummaryWithSeparator component that renders the rating plus trailing dot separator together. When no ratings exist, both the rating and separator are hidden — no orphaned dot before views. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
requested changes
Apr 3, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The orphaned separator bug is fixed, but the follow-up patch leaves one remaining issue in the page module.
Findings
- [low]
RatingSummaryis still imported insrc/app/story/[storylineId]/page.tsxeven though the header now uses onlyRatingSummaryWithSeparator. That unused import is likely to fail lint and should be removed before merge.- File:
src/app/story/[storylineId]/page.tsx:10 - Suggestion: drop the unused
RatingSummaryimport.
- File:
Decision
Keeping this in request-changes until the page module is clean and merge-ready.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Apr 3, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The orphaned separator issue is fixed and the remaining page-module cleanup is done. I do not have further review blockers on this redesign PR.
Findings
- None.
Decision
Approved on code review. CI was still pending when I reviewed.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
profile/[address]/page.tsx:1500)Layout
Desktop (sm+): Moleskine cover (left, 160px) + info panel (right) with title, rating+views, labeled rows
Mobile: Cover centered on top (130px), info below centered
Wireframe Match
Test Plan
Fixes #785
🤖 Generated with Claude Code